Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename QubitStateVector to StatePrep #326

Merged
merged 5 commits into from
Aug 22, 2023
Merged

Conversation

Jaybsoni
Copy link
Contributor

Following the work here, we make sure that the pennylane-qiskit plugin supports both operators and defaults to using StatePrep where appropriate until it is deprecated.

Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will check again when it works : p

@@ -129,15 +129,15 @@ def execute_supported_operation(operation_name: str, parameters: list, wires: li
"""Utility function that executes an operation that is natively supported by PennyLane.

Args:
operation_name (str): wires specified for the template
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right LOL

pennylane_qiskit/converter.py Outdated Show resolved Hide resolved
@@ -1,4 +1,4 @@
pennylane>=0.30
git+https://github.com/PennyLaneAI/pennylane.git
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this before merge

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and by revert you mean bump to 0.32 : )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends if it gets merged before the pre-release version bumps LOL 👍🏼

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to the RC branch and I'd be happy to merge today 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL, you just want me to do the pre-release bump for you

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want you to not get experimental changes for 0.33 from master : )

@Jaybsoni
Copy link
Contributor Author

[sc-43547]

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #326 (6f52915) into master (2aec977) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #326   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          314       314           
=========================================
  Hits           314       314           
Files Changed Coverage Δ
pennylane_qiskit/converter.py 100.00% <100.00%> (ø)
pennylane_qiskit/qiskit_device.py 100.00% <100.00%> (ø)

@timmysilv timmysilv merged commit 22b7e20 into master Aug 22, 2023
10 checks passed
@timmysilv timmysilv deleted the rename_qsv_state_prep branch August 22, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants