Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin Qiskit where relevant #508

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Unpin Qiskit where relevant #508

merged 6 commits into from
Apr 10, 2024

Conversation

lillian542
Copy link
Contributor

@lillian542 lillian542 commented Apr 1, 2024

  • Change requirements-ci.txt files so that there is a legacy and a standard version, and the standard versions tests vs Qiskit 1.0.
  • Unpin qiskit and qiskit-ibm-runtime where relevant

See the pip freeze print-out in the Install Plugin section of the tests to confirm that they are run with the expected version numbers.

@lillian542 lillian542 marked this pull request as ready for review April 1, 2024 21:17
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a793665) to head (d9c0486).

Additional details and impacted files
@@               Coverage Diff               @@
##           compatibility      #508   +/-   ##
===============================================
  Coverage         100.00%   100.00%           
===============================================
  Files                  7         7           
  Lines                556       556           
===============================================
  Hits                 556       556           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lillian542
Copy link
Contributor Author

[sc-57197]

Copy link
Contributor

@astralcai astralcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@lillian542 lillian542 merged commit 647d64c into compatibility Apr 10, 2024
13 checks passed
@lillian542 lillian542 deleted the unpin branch April 10, 2024 15:29
lillian542 added a commit that referenced this pull request Apr 10, 2024
* remove deprecated installation syntax from test yaml

* run all the test vs Qiskit 1.0

* update to only raise error for BasicAer

* add missing import

* reorganize test parameterization for 1.0

* remove unused import

* add a BasicSimulator device

* import BasicSimulatorDevice

* update combinations of test devices and backends

* update devices and backends in integration tests

* update tests for incompatible devices and versions

* update QiskitDevice tests to use IBMQ instead of BasicAer

* tweak QiskitDevice for compatibility with BasicSimulator

* fix bad relative import path

* skip devices in  conftest with incompatible provider-backend combinations

* qasm_simulator is just qasm_simulator for old qiskit too now

* more fixes for combinations of providers and backends

* move import to top level

* update to supported backends in test_qiskit_device.py

* correct Regex pattern for error test

* update providers and backends in test_integration.py

* trigger ci

* use provider that doesn't requre token

* run device integration tests with 1.0

* correct backend for 1.0 device integration tests

* upload 1.0 test results to codecov

* add IBMQ tests with 1.0

* add basicsim device to documentation

* update install instructions

* update changelog

* update basicsim documentation

* update docstring for basicsim

* cutoff for basicaer is 0.46 instead of 0.45.3

* remove whitespace

* black formatting

* indicate partial version number

* small docs update

* Apply suggestions from code review

Co-authored-by: Thomas R. Bromley <[email protected]>

* rearrange order of device cards on docs page

* docs updates

* Update doc/devices/basicsim.rst

Co-authored-by: Thomas R. Bromley <[email protected]>

* add reference

* correct reference

* maybe it doesn't like underscores?

* update reference

* update refs

* add custom analytic not supported msg for BasicProvider device

* update warning

* remove unused import

* remove kwarg section of basic_simulator docstring

* trigger ci

* Unpin Qiskit where relevant (#508)

* update to use requirements-ci and requirements-ci-legacy

* unpin qiskit-ibm-runtime

* add explicit qiskit-ibm-runtime requirement

* unpin in upload yaml

* update changelog

* add codecov token for 1.0 tests

* add codecov token for 1.0 tests one more place

---------

Co-authored-by: Thomas R. Bromley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants