BackendV2 support for old device API #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #514 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 557 557
=========================================
Hits 557 557 ☔ View full report in Codecov by Sentry. |
lillian542
reviewed
Apr 19, 2024
austingmhuang
changed the title
There was a problem hiding this comment.
Thanks @austingmhuang, this looks great! Just leaving a couple of suggestions
lillian542
reviewed
Apr 19, 2024
austingmhuang
changed the title
lillian542
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Thanks @austingmhuang!
Let's remove the .DS_Store file, that's just a thing that happens locally on Macs, we shouldn't need it on GitHub. But otherwise looks good to go to me! 🎉
soranjh
reviewed
Apr 19, 2024
soranjh
reviewed
Apr 19, 2024
Co-authored-by: soranjh <[email protected]>
obliviateandsurrender
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to provide support for V2 devices using the old device API. This addresses an issue from a user requesting this feature. There is a similar PR open for the new device API as well, but that might not be ready with the 0.36 release.