Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI #16

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Fix CLI #16

merged 1 commit into from
Sep 14, 2023

Conversation

NeffIsBack
Copy link
Contributor

This PR should fix the problem that:

  1. Binary building workflow run after every push -> now only when manually triggered
  2. Test running after every push -> now only run after a review has been submitted

@NeffIsBack NeffIsBack added the bug-fix This Pull Request fixes a bug label Sep 13, 2023
Marshall-Hallenbeck
Marshall-Hallenbeck approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@Marshall-Hallenbeck Marshall-Hallenbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NeffIsBack NeffIsBack merged commit ceddcb6 into main Sep 14, 2023
20 checks passed
@NeffIsBack NeffIsBack deleted the neff-fix-cli branch September 14, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marshall-Hallenbeck Marshall-Hallenbeck Marshall-Hallenbeck approved these changes

Assignees
No one assigned
Labels
bug-fix This Pull Request fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeffIsBack @Marshall-Hallenbeck