Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lib] Improve ntlm_parser.py #191

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Conversation

XiaoliChan
Copy link
Contributor

@XiaoliChan XiaoliChan commented Feb 29, 2024

  • Using the function from impacket's DumpNTLMInfo.py is much better than before.

image

XiaoliChan added a commit to XiaoliChan/NetExec that referenced this pull request Feb 29, 2024
@XiaoliChan XiaoliChan mentioned this pull request Feb 29, 2024
@Marshall-Hallenbeck
Copy link
Collaborator

Running tests for this now

@mpgn
Copy link
Collaborator

mpgn commented Feb 29, 2024

not tested but i like the simplicity

@NeffIsBack NeffIsBack added the enhancement New feature or request label Mar 1, 2024
Copy link
Contributor

@NeffIsBack NeffIsBack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@NeffIsBack NeffIsBack merged commit 31b2a1f into Pennyw0rth:main Mar 3, 2024
1 check passed
@XiaoliChan XiaoliChan deleted the ntlm_parser branch March 3, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants