Revert #190 to enable null-auth without explicit specification

[NeffIsBack]

PR to test if #207 is fixed with empty string auth (null auth)

[mpgn]

to be tested but it should work ok

Fix this issue

[NeffIsBack]

Hmm that will always show the null auth tho. A lot of unnecessary output when you do nxc smb <ip>/24 --shares.
I would vote for just leaving it as it is and wait until that error occurs the next time. Then i can debug it properly, i really don't know how this should have happened (refering to the index out of bounds)

[mpgn]

Show me a screenshot of the output you see because I don't understand what you mean

[mpgn]

If you don't want any output if no -u -p then this pr should not be merged

[NeffIsBack]

That one is what i meant. That was the error you are aiming to fix right?

[NeffIsBack]

If you don't want any output if no -u -p then this pr should not be merged

Yeah i just would like to roll it back to how it was all that time.

[mpgn]

Then merge the pr 🙂

[mpgn]

to be tested but it should work ok

Fix this issue

Before and after

Follow the code with an empty array (the fix don't allow empty array) you will see it makes no sens to send an empty array since login will be false but username and password to "" will bypass the login check.
Then you go on shares function without a login working making the exception.

With the fix, you send "" to the smb login function and not empty array making it properly check the login

To simplify, my commit is the equivalent to send -u "" -p "" but without adding them into the command line

[mpgn]

On the other end, i didn't check the gen-relay option, if not working then my commit need to be removed

Can you check ? 🙏

[Marshall-Hallenbeck]

Just tested, gen relay works on this PR