-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set computer accounts as owned in bloodhound if local admin privs #90
Conversation
We could probably delete the bh_owned module now |
Signed-off-by: Marshall Hallenbeck <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it's just me, but setting the bloodhound flag in every protocol seems pretty bad and unmanageable. Is there anyway we could move it to a centralized place?
Agreed. When you look into these functions the whole block of code mostly the same across the protocols. I just added it to the end of the block but we should centralise a lot of the code probably, but I didn't want to do it in this PR. It is probably a bigger problem. I can do it in this PR but we should imo open up another one where we tackle the big problem on its own. |
Signed-off-by: Marshall Hallenbeck <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #96 for us to look into and fix it at a later time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good but I haven't ran tests since I haven't set up Bloodhound yet. If you've confirmed it works then it should be good to go.
If you achieve to gain local admin privileges you basically have control over the comuter account. Therefore this is account is set to owned in bloodhound now. (Even with NetBIOS name support for the domain 😁)
FYI: this is branched of #35 so it is already up-to-date if this one gets merged