Fixing integer overflow bugs in Perl_my_setenv #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 18, 2019
Closed
Closed
Closed
This was referenced Oct 19, 2019
|
Closing as this was already resolved by 34716e2 |
This was referenced Feb 2, 2020
demerphq
added a commit
that referenced
this pull request
Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using 32 bit integers to store return value of strlen might lead to integer overflow vulnerability while allocating a buffer. This could then possibly lead to a buffer overflow vulnerability on the heap.
Not sure if the variable max, declared @ util.c : 2093 needs to be initialised to a 64 bit integer as well.
If it is possible for environ to have 2^32 - 2 entries, max should probably be 64 bits in length as well.
I would like to hear what you think about this.