Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pl2bat use ExtUtils::PL2Bat #17565

Merged
merged 4 commits into from
Jul 30, 2020
Merged

Make pl2bat use ExtUtils::PL2Bat #17565

merged 4 commits into from
Jul 30, 2020

Conversation

Leont
Copy link
Contributor

@Leont Leont commented Feb 14, 2020

This adds a new module called ExtUtils::PL2Bat, and refactors the pl2bat to use it.

This way, we can finally unify all three implementations of pl2bat into one codebase that has tests

This is probably too late for 5.32 though

@Leont Leont added cpan-dual-life issues regarding dual-life cpan-first distributions distro-mswin32 type-install type-Module labels Feb 14, 2020
@Leont Leont changed the title Make pl2bat Make pl2bat use ExtUtils::PL2Bat Feb 14, 2020
atoomic
atoomic approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@atoomic atoomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine

@khwilliamson khwilliamson added the do not merge Don't merge this PR, at least for now label Mar 13, 2020
@khwilliamson
Copy link
Contributor

Labelling as do not merge, since author says it is too late for 5.32

@atoomic
Copy link
Member

atoomic commented Mar 13, 2020

adding the label target-5.34 to make the intent clear so we know what to wait

@toddr toddr added this to the 5.33.1 milestone May 19, 2020
@toddr
Copy link
Member

toddr commented May 19, 2020

@atoomic @khwilliamson I've been using the 5.33.1 milestone for these.

@toddr
Copy link
Member

toddr commented May 19, 2020

@Leont should we be closing #11 as this will replace it?

@Leont
Copy link
Contributor Author

Leont commented May 19, 2020

@Leont should we be closing #11 as this will replace it?

Yes, this branch contains a very similar fix

@toddr toddr mentioned this pull request May 19, 2020
Closed
@Leont Leont removed the do not merge Don't merge this PR, at least for now label Jun 21, 2020
@khwilliamson khwilliamson merged commit 88e7da0 into blead Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoomic atoomic atoomic approved these changes

Assignees
No one assigned
Labels
cpan-dual-life issues regarding dual-life cpan-first distributions distro-mswin32 target-5.34 type-install type-Module
Projects
None yet
Milestone
5.33.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Leont @khwilliamson @atoomic @toddr