Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH #18163: Stricter, cleaned up test example: #18165

Merged
merged 11 commits into from
Dec 23, 2020
Merged

GH #18163: Stricter, cleaned up test example: #18165

merged 11 commits into from
Dec 23, 2020

Conversation

xsawyerx
Copy link
Member

This just adds my $i to make the test pass on strict, and it cleans it up and provides test names for the tests.

I kept the tabs that were used.

@xsawyerx xsawyerx self-assigned this Sep 25, 2020
@xsawyerx xsawyerx linked an issue Sep 25, 2020 that may be closed by this pull request
[doc] perlxstut update #18163
Closed
@xsawyerx
GH #18163: Stricter, cleaned up test example:
088fd70 
This just adds 'my $i' to make the test pass on strict, and it cleans
it up and provides test names for the tests.

I kept the tabs that were used.
@atoomic
Copy link
Member

atoomic commented Sep 28, 2020

@xsawyerx notice some errors from smokers while running porting/podcheck.t
please confirm the length is ok

#   "Verbatim line length including indents exceeds 79 by" 
#     +2 (including 0 from =over's) near line ***269 of dist/ExtUtils-ParseXS/lib/perlxstut.pod

atoomic
atoomic requested changes Sep 28, 2020
View reviewed changes
Copy link
Member

@atoomic atoomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix porting/podcheck.t

@xsawyerx
Copy link
Member Author

xsawyerx commented Oct 4, 2020

please fix porting/podcheck.t

Fixed.

@xsawyerx xsawyerx mentioned this pull request Oct 6, 2020
Closed
@Grinnz Grinnz removed the type-docs label Oct 30, 2020
@jkeenan
Copy link
Contributor

jkeenan commented Dec 22, 2020

Is there any reason why this patch should not be merged into blead?

Thank you very much.
Jim Keenan

@khwilliamson khwilliamson merged commit c389fd8 into blead Dec 23, 2020
@rjbs rjbs deleted the docs/strict-xstut-test branch May 8, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grinnz Grinnz Grinnz left review comments

@atoomic atoomic atoomic requested changes

Assignees

@xsawyerx xsawyerx

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[doc] perlxstut update
5 participants
@xsawyerx @atoomic @jkeenan @Grinnz @khwilliamson