-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
comp/parser.t count two tests #18308
Conversation
…rashed parser as tests (PASS if the test file is still running after the lines).
Not sure I see the point of the block, Nothing within it is lexically scoped. |
3 similar tests eval a sub with a list of variables, $r is repeated at the end of the list, but the errors that are being checked have nothing to do with the repeated variable. This causes a warning enabled.
Found what I think is a typo in parser.t adding to pull request. The typo causes 'redefined' warnings when warnings are enabled. The point of the block is that for Perl 7 some warnings need to be disabled, for Perl 5 the only purpose is it groups the code making it more readable. The lines that I added tests for should be counted as tests. |
I don't know what that means. There are no warnings being disabled here. Also, it is unknown what Perl 7 will entail. |
I've removed the braces. |
Rather than |
The test doesn't use test::more or test.pl and doesn't have a pass routine defined. |
Ahh, you're right, sorry for the noise. I've squashed the braces change into the base commit, rebase and applied your changes to blead as 4281700 and a5fba4f. |
Two lines in comp/parser.t were present to make sure they didn't crash the parser.
I enclosed the relevant section in a block {.
I added Pass tests immediately after each of the two lines.
Motiviation: I was working on Perl 7 Alpha tests, this section of the code generates warnings that need silencing and it is easier to see all the related code and comment when the section is grouped together in a block. Since each of the two lines is testing something it should be counted as a test.