Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enum messages: Make the returned values all 'static #160

Merged
merged 2 commits into from
May 18, 2021

Conversation

ijackson
Copy link
Contributor

This is (at least in theory) a breaking change, because someone might
have implemented this trait by hand, and their implementation won't
be declared as returning 'static lifetimes.

Closes #159

This is (at least in theory) a breaking change, because someone might
have implemented this trait by hand, and their implementation won't
be declared as returning 'static lifetimes.

Closes Peternator7#159

Signed-off-by: Ian Jackson <[email protected]>
@ijackson
Copy link
Contributor Author

ijackson commented May 12, 2021

The Travis failure CI failures seem unrelated:

error[E0658]: use of unstable library feature 'alloc': this library is unlikely to be stabilized in its current form or name (see issue #27783)

   --> /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/enum_variant_type-0.2.1/src/lib.rs:144:1

    |

144 | extern crate alloc;

    | ^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0658`.

error: Could not compile `enum_variant_type`.

@Peternator7
Copy link
Owner

Fixed the build with #162, could you merge master and re-push?

This seems generally useful to me so I'm okay taking the small chance of breaking existing code.

@ijackson
Copy link
Contributor Author

The AppVeyor failure is this:

verbose: creating temp file: C:\Users\appveyor\.rustup\tmp\5vzkbz8b4rvu6tfk_file
verbose: creating temp file: C:\Users\appveyor\.rustup\tmp\5wypi_xgi7diffwp_file
verbose: deleted temp directory: C:\Users\appveyor\.rustup\tmp\b658ydoei39unwji_dir
info: installing component 'rust-std'
verbose: creating temp directory: C:\Users\appveyor\.rustup\tmp\h32i514dflmtq_j2_dir
memory allocation of 16777216 bytes failed
Command exited with code -1073740791

The error code is 0xffffffffc0000409. No idea what that means. I don't think this is related to my changes.

@Peternator7
Copy link
Owner

Appveyor has been flakey lately. Re-running fixed the gate

@Peternator7 Peternator7 merged commit 3869b6f into Peternator7:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lifetimes overly-strict in EnumMessage
2 participants