Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EnumCount with disabled variants #268

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

schultetwin1
Copy link
Contributor

Do not include disabled variants in the count with EnumCount. Fixes #267

Do not include disabled variants in the count with EnumCount. Fixes Peternator7#267
@Peternator7
Copy link
Owner

Thanks for the PR! I'm in favor of this change, but it's a breaking change so I just need to figure out what release to bundle it into.

@schultetwin1
Copy link
Contributor Author

Not a problem! Sounds good!

@schultetwin1
Copy link
Contributor Author

Thanks for the PR! I'm in favor of this change, but it's a breaking change so I just need to figure out what release to bundle it into.

I added a feature flag to make this no longer a breaking change. Are you open to using a feature flag here? Whenever we want to make this breaking change in the future, we can just enable the feature by default?

@Peternator7
Copy link
Owner

Thanks for continuing to think about this. Let's actually remove the feature flag and I'm going to put a couple of breaking changes into 0.25.

@schultetwin1
Copy link
Contributor Author

Thanks for continuing to think about this. Let's actually remove the feature flag and I'm going to put a couple of breaking changes into 0.25.

Sounds good! Done!

@Peternator7 Peternator7 merged commit 67f0d19 into Peternator7:master Jun 18, 2023
@schultetwin1 schultetwin1 deleted the disabled_count branch June 18, 2023 04:37
@Peternator7
Copy link
Owner

Just release 0.25.0 which has this upgrade! Thanks for putting the work in :)

@schultetwin1
Copy link
Contributor Author

Amazing, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled variant still included in Count
2 participants