Add checks to guard against overflow in iterator methods. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! Thanks for the PR :) |
Ten0
reviewed
Nov 23, 2021
| output | ||
| } | ||
|
|
||
| fn size_hint(&self) -> (usize, Option<usize>) { | ||
| let t = #variant_count - self.idx; | ||
| let t = if self.idx >= #variant_count { 0 } else { #variant_count - self.idx }; |
There was a problem hiding this comment.
Looks like this is unnecessary given that the above guarantees this will never underflow.
Additionally, this property is FusedIterator (which is not a requirement for Iterator, and it's the responsibility of the caller to stop calling it). If we choose to have it, then we should also signify that we have it by implementing FusedIterator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a generated iterator runs of the end it keeps on incrementing the index variable, which is undesirable. Furthermore the size_hint method does not guard against the index being greater than the variant count, which causes an overflow.
These issues cause our static analyses tool to generate warnings when analyzing code generated by strum, which is annoying.
Thanks for considering this.