Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

untracked tabs shouldn't be treated as ignored #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paulirish
Copy link

I was debugging why the extension wasn't detecting several duplicate cases.

I isolated it to this.

TBH I don't fully understand what this ignored state is meant to capture, but.... it does seem reasonable to not exclude items from evaluation even if the bookkeeping isn't up to date.

@paulirish
Copy link
Author

Okay nvm

it looks like when we end up in a this.tabs.get(tabId) === undefined case, a bunch of things break.

I fixed it, for now, by disabling and re-enabling the extension.

@erdnuesse
Copy link

erdnuesse commented Mar 6, 2024

As this piece of useful code looks like no longer maintained and you're already debugging, maybe you want to fork it and keep it alive?
Just checking if someone is actually willing to bring that functionality back to "life".
Best regards.

@paulirish
Copy link
Author

i dont have the time to maintain it. but.. the good news is.. im still using it and it hasnt broken yet. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants