automated translation from coding to english #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alondmnt
reviewed
Dec 27, 2023
pheno_utils/pheno_loader.py
Outdated
| @@ -64,6 +66,7 @@ class PhenoLoader: | |||
| valid_stage (bool): Whether to ensure that all research stages in the data are valid. | |||
| flexible_field_search (bool): Whether to allow regex field search. | |||
| errors (str): Whether to raise an error or issue a warning if missing data is encountered. | |||
| auto_translate (bool): Whether to automatically translate the data from coding to english. | |||
There was a problem hiding this comment.
consider the following alternative:
instead of the word "translation", and a boolean value,
use something like preferred_language="coding" (or a better similar name of your choice) that accepts ["hebrew", "english", "coding"].
this can be readily extended to other languages if needed.
also, perhaps in the config we can set the default value for preferred_language (like other PhenoLoader args). maybe some customers will prefer an english default, and others a coding default.
but maybe you considered this and had a good reason to go for a boolean translation approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically transforms decoded questionnaire answers
from code to english