-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BrAPI Workflow UI #1048
Draft
chaneylc
wants to merge
15
commits into
main
Choose a base branch
from
brapi_workflows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
BrAPI Workflow UI #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flows # Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/com/fieldbook/tracker/activities/brapi/update/BrapiCropsFilterActivity.kt # app/src/main/java/com/fieldbook/tracker/activities/brapi/update/BrapiFilterActivity.kt # app/src/main/java/com/fieldbook/tracker/activities/brapi/update/BrapiProgramFilterActivity.kt # app/src/main/java/com/fieldbook/tracker/activities/brapi/update/BrapiSeasonsFilterActivity.kt # app/src/main/java/com/fieldbook/tracker/activities/brapi/update/BrapiStudyFilterActivity.kt # app/src/main/java/com/fieldbook/tracker/activities/brapi/update/BrapiStudyImportActivity.kt # app/src/main/java/com/fieldbook/tracker/activities/brapi/update/BrapiTrialsFilterActivity.kt # app/src/main/java/com/fieldbook/tracker/brapi/service/BrAPIServiceV2.java # app/src/main/java/com/fieldbook/tracker/brapi/service/core/BrapiAlias.kt # app/src/main/java/com/fieldbook/tracker/brapi/service/core/ProgramService.kt # app/src/main/java/com/fieldbook/tracker/brapi/service/core/SeasonService.kt # app/src/main/java/com/fieldbook/tracker/brapi/service/core/StudyService.kt # app/src/main/java/com/fieldbook/tracker/brapi/service/core/TrialService.kt # app/src/main/java/com/fieldbook/tracker/dialogs/BrapiFilterBottomSheetDialog.kt # app/src/main/res/layout/activity_brapi_importer.xml
|
various ui updates filtered level selection to those that exist, view is disabled until all data is received changed text filtering to AND unique tokens instead of OR trials are now filtered by chosen program seasons are filtered by program and trial
…s in a selected study
fix observation levels showing when they don't exist as units
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New UI for BrAPI study import
Required BrAPI calls:
GET studies / trials are required, latter is needed to filter by program since program data is not included in study objects
GET commonCropNames, trials, seasons, programs
GET observationlevels (although I noticed servers implement this differently, some don't return anything when supplying a programDbId, in that case you have to supply null)
GET observationVariables (from previous implementation, traits are imported with the studies)
GET observationUnits
GET germplasms (used to populate unit attribute table further)
Tested on BrAPI test server and Cassavabase.
The test server seems to have only one study that contains plots.
Cassavabase has a lot of data, making filtering interesting, but most calls take a long time to load.
Type of change
What type of changes does your code introduce? Put an
x
in boxes that apply.CHANGE
(fix or feature that would cause existing functionality to not work as expected)FEATURE
(non-breaking change which adds functionality)BUGFIX
(non-breaking change which fixes an issue)ENHANCEMENT
(non-breaking change which improves existing functionality)NONE
(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)