Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hbs helpers to use the latest from kss-node #12

Closed
wants to merge 1 commit into from
Closed

Update hbs helpers to use the latest from kss-node #12

wants to merge 1 commit into from

Conversation

davidtheclark
Copy link
Contributor

The current Handlebars helpers file is outdated. It does not contain the helpers necessary to render a custom template started from kss-node --init, hence #11.

It looks to me like this file was just a copy-paste job from a previous version of kss-node; so this pull request is simply another copy-paste job from the current version.

Using this new helpers file worked for me with the default template version that arrives with gulp-kss and also worked with a new custom template generated from kss-node --init.

The current Handlebars helpers file is outdated. It does not contain the helpers necessary to render a custom template started from `kss-node --init`, hence #11.

It looks to me like this file was just a copy-paste job from a previous version of kss-node; so this pull request is simply another copy-paste job from the current version.

Using this new helpers file worked for me with the default template version that arrives with gulp-kss and also worked with a new custom template generated from `kss-node --init`.
@RobLoach
Copy link

This would be a good one to have.

@vocino
Copy link

vocino commented Oct 13, 2014

Can we get this merged?

@nickradford
Copy link

👍 Can we please merge this?

@nielsboogaard
Copy link

👍 !

@RobLoach
Copy link

RobLoach commented Jan 9, 2015

In other news, I've switched over to using gulp-exec and interacting directly with the kss-node binary. Much simpler to work with, and more up to date than using this bridge.

@RobLoach
Copy link

For those of you looking for that exec snippet:

Gulpfile.js

var gulp = require('gulp');
var exec = require('child_process').exec;
gulp.task('kss', function(cb){
  exec('npm run kss', function (err, stdout, stderr) {
    console.log(err);
    console.log(stdout);
    console.log(stderr);
  });
});

package.json

{
  "scripts": {
    "kss": "kss-node --config='kss-node.json'"
  }
}

kss-node.json

{
  "source": [
    "styles"
  ],
  "destination": "styleguide"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants