Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PercentFormatter: make space between number and percent sign optional #4512

Merged
merged 2 commits into from
Apr 27, 2019

Conversation

duchampdev
Copy link
Contributor

PR Checklist:

  • I have tested this extensively and it does not break any existing behavior.
  • [-] I have added/updated examples and tests for any new behavior.

PR Description

This PR makes the space between the number and the percent sign in PercentFormatter optional.
It preserves the current behaviour (insert space) as default but allows for not inserting the space.
As there is no definite convention on wether to insert a space or not, the user should imho have the opportunity to choose.

@duchampdev duchampdev marked this pull request as ready for review April 27, 2019 14:25
@PhilJay PhilJay merged commit 2340e12 into PhilJay:master Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants