Bump typescript from 4.9.5 to 5.0.2

[dependabot]

Bumps typescript from 4.9.5 to 5.0.2.

Release notes

Sourced from typescript's releases.

TypeScript 5.0 Beta

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

• fixed issues query for Typescript v5.0-beta.

Downloads are available on:

• npm
• NuGet package

Commits

• See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[codecov]

Codecov Report

Patch coverage: 94.87% and project coverage change: +0.35 🎉

Comparison is base (2c55cab) 95.30% compared to head (db9dd7d) 95.65%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
+ Coverage   95.30%   95.65%   +0.35%     
==========================================
  Files          48       48              
  Lines         830      828       -2     
  Branches      151      150       -1     
==========================================
+ Hits          791      792       +1     
+ Misses         38       35       -3     
  Partials        1        1              

Impacted Files	Coverage Δ
src/errors/index.ts	100.00% <ø> (ø)
src/middleware/verifyJwt.ts	71.42% <71.42%> (ø)
src/auth/jwtOptions.ts	100.00% <100.00%> (ø)
src/logger.ts	100.00% <100.00%> (ø)
src/middleware/errorHandler.ts	100.00% <100.00%> (ø)
src/routers/applicantsRouter.ts	100.00% <100.00%> (ø)
src/routers/applicationFormsRouter.ts	100.00% <100.00%> (ø)
src/routers/canonicalFieldsRouter.ts	100.00% <100.00%> (ø)
src/routers/documentationRouter.ts	100.00% <100.00%> (+15.78%)	⬆️
src/routers/opportunitiesRouter.ts	100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[bickelj]

502 - 495 = 7
7 / 495 = 0.014
That's only a 1.4% change, obviously a minimal change and safe to upgrade, right?
/sarcasm

Seriously, though, our tests passed, so it is probably safe. But the major version change suggests potentially breaking changes. Do we want to upgrade, @slifty, @reefdog, @gmurtaza00, @jasonaowen ?

[jasonaowen]

I looked through the release notes, and especially the breaking changes section, and did not see anything concerning. CI does include a build step, so I think we have a reasonable level of confidence that there are no breaking changes here.

Note the codecov/patch check seems to be a failure relating to #124; I noticed then that codecov hadn't run on the latest force push to that PR's branch, but I don't know why. I'm fine to merge despite that.

[jasonaowen]

Oh, note that running the tests now produces a warning:

ts-jest[versions] (WARN) Version 5.0.2 of typescript installed has not been tested with ts-jest. If you're experiencing issues, consider using a supported version (>=4.3.0 <5.0.0-0). Please do not report issues in ts-jest if you are using unsupported versions.

There is an upstream issue open: kulshekhar/ts-jest#4048

I don't think this is enough to revert over, as the tests still pass, but I am happy to be overridden by @bickelj or @slifty.

[bickelj]

If our tests pass (they did) I am happy to upgrade. I think we just keep it in mind if there are weird test issues in the future and try 4.x locally to see if that was it. But hopefully by that time ts-jest will have a new version supporting 5 anyhow.