Update for Symfony 5 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symfony 5 depreciations fix
Symfony 5 depreciations fix
Symfony 5 depreciations fix
Symfony 5 depreciations fix
Symfony 5 depreciations fix
Symfony 5 depreciations fix
|
Are there any plans to merge this PR? |
|
@Gemineye, awaiting response from the developer. |
|
@BrandonFlude thank you very much for your contribution! |
|
@Phobetor - sure can. |
|
@Phobetor - any chance we can get a tag out for this so we can pull through composer with the latest version? Thanks! |
+1 |
|
Thank you very much for this pull request! It is released in version (fyi @Gemineye ) |
|
@Phobetor thanks! Maybe you should remove the usage of kernel.root_dir. I had to add this paramter: kernel.root_dir: '%kernel.project_dir%' |
Mapsred
pushed a commit
to igraal/rabbitmq-supervisor-bundle
that referenced
this pull request
Mar 18, 2021
add return values to commands add symfony 5 instructions to readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command must return an INT, often 0 - update Composer to accept 5.0.* versions of Symfony packages.