Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions #117

Merged
merged 6 commits into from
Nov 13, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
path: /tmp/composer-cache
key: ${{ runner.os }}-${{ hashFiles('**/composer.lock') }}

- uses: php-actions/composer@v5
- uses: php-actions/composer@v6

- name: Archive build
run: mkdir /tmp/github-actions/ && tar -cvf /tmp/github-actions/build.tar ./
Expand All @@ -40,9 +40,9 @@ jobs:
run: tar -xvf /tmp/github-actions/build.tar ./

- name: PHP Unit tests
uses: php-actions/phpunit@v2
uses: php-actions/phpunit@v3
with:
php_version: 8.0
php_version: 7.3
php_extensions: xdebug
configuration: test/phpunit/phpunit.xml
bootstrap: vendor/autoload.php
Expand All @@ -61,6 +61,6 @@ jobs:
run: tar -xvf /tmp/github-actions/build.tar ./

- name: PHP Static Analysis
uses: php-actions/phpstan@v2
uses: php-actions/phpstan@v3
with:
path: src/
6 changes: 3 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "library",

"require": {
"php": ">=7.4"
"php": ">=7.3"
},

"require-dev": {
Expand All @@ -26,7 +26,7 @@
"Gt\\CssXPath\\Test\\": "./test/phpunit"
}
},

"authors": [
{
"name": "Greg Bowler",
Expand All @@ -35,7 +35,7 @@
"role": "Developer"
}
],

"funding": [
{
"type": "github",
Expand Down
6 changes: 4 additions & 2 deletions src/Translator.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,10 @@ class Translator {
const EQUALS_STARTS_WITH_OR_STARTS_WITH_HYPHENATED = "|=";
const EQUALS_STARTS_WITH = "^=";

protected string $cssSelector;
protected string $prefix;
/** @var string */
protected $cssSelector;
/** @var string */
protected $prefix;

public function __construct(string $cssSelector, string $prefix = ".//") {
$this->cssSelector = $cssSelector;
Expand Down