Fix codecov to ignore 3rdparty folder #26
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrygerardmoore
force-pushed
the
codecov_ignore_3rdparty
branch
14 times, most recently
from
72bfc92
to
4a25d66
Compare
henrygerardmoore
force-pushed
the
codecov_ignore_3rdparty
branch
from
4a25d66
to
e23eda5
Compare
|
Looks good to me, this is something I was struggling with! |
I tried a million different things and couldn't get it 🫠 ! I will let you know when it's ready though 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like we're trying to ignore codecov for the 3rd party folder, but it's included nonetheless. This PR fixes that to get a more accurate codecov value
Currently:
After this PR:
[trying to get codecov to cooperate]