-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing primary view switch in teleop Joints Jog #381
Removing primary view switch in teleop Joints Jog #381
Conversation
One thing I noticed when testing this out is the joint jog panel does not render over the BT pane, so if it is selected as the primary view then the joint jog panel does not appear. The previous requirement to change primary panes to Visualization masked this issue, but now it is not longer prevented. I would say that the issue I noted is less painful than the panes jumping around on you, but I would like to hear @Hoffalypse thoughts on how we can either:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Played around with it, the sliders are kind of in the way of the robot but they don't jump around and the scene seems stable. Resized my window a few times too and had no issues
Unsure if this is a separate issue, but when I change the order of the multipane and then click one of the Teleop tabs, the Vizualization pane always jumps into the top left corner -- is that intended behavior?
@MikeWrock This will be fixed in #9069. The pane will not jump but all functionality will be shown in the visualization pane no matter where it exists now. I think this creates the best UX as I generally feel the less jumping the better. |
@mewtwoshaurd are you using a recent version of main. They shouldnt jump when switched anymore. |
@Hoffalypse this is on the most recent main branch I just build: 2024-10-22.15-51-43.mp4 |
OK I may have spoke too soon, I apologize, it was in the merge Queue. Should be GTG now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double checked with new main and seems to work well -- I think I encountered a different UI bug that I'll make a ticket for, but these changes work
This is a removal of two
switchUIPrimaryView' behaviors. They are both tied to the
RequestTeleoperation` subtree. They are being removed so that in multi pane view when moving the sliders the view does not jump back to the main pane.