Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing primary view switch in teleop Joints Jog #381

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

Hoffalypse
Copy link
Contributor

This is a removal of two switchUIPrimaryView' behaviors. They are both tied to the RequestTeleoperation` subtree. They are being removed so that in multi pane view when moving the sliders the view does not jump back to the main pane.

@Hoffalypse Hoffalypse added this to the 2.4 milestone Oct 9, 2024
@Hoffalypse Hoffalypse self-assigned this Oct 9, 2024
@EzraBrooks EzraBrooks requested review from MikeWrock and mewtwoshaurd and removed request for EzraBrooks October 21, 2024 15:23
@MikeWrock
Copy link
Contributor

One thing I noticed when testing this out is the joint jog panel does not render over the BT pane, so if it is selected as the primary view then the joint jog panel does not appear. The previous requirement to change primary panes to Visualization masked this issue, but now it is not longer prevented.

I would say that the issue I noted is less painful than the panes jumping around on you, but I would like to hear @Hoffalypse thoughts on how we can either:

  • Force the visualization pane to be primary only when the BT pane is currently the primary pane
  • Render joint jog over the BT pane
  • Pop a warning that joint jog is not shown when BT is the primary pane (and tell the user to change the primary pane to something else)

mewtwoshaurd
mewtwoshaurd previously approved these changes Oct 22, 2024
Copy link

@mewtwoshaurd mewtwoshaurd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Played around with it, the sliders are kind of in the way of the robot but they don't jump around and the scene seems stable. Resized my window a few times too and had no issues

Unsure if this is a separate issue, but when I change the order of the multipane and then click one of the Teleop tabs, the Vizualization pane always jumps into the top left corner -- is that intended behavior?

@mewtwoshaurd mewtwoshaurd dismissed their stale review October 22, 2024 20:26

found different error to clarify

@mewtwoshaurd mewtwoshaurd self-requested a review October 22, 2024 20:27
@Hoffalypse
Copy link
Contributor Author

@MikeWrock This will be fixed in #9069. The pane will not jump but all functionality will be shown in the visualization pane no matter where it exists now. I think this creates the best UX as I generally feel the less jumping the better.

@Hoffalypse
Copy link
Contributor Author

@mewtwoshaurd are you using a recent version of main. They shouldnt jump when switched anymore.

@mewtwoshaurd
Copy link

@Hoffalypse this is on the most recent main branch I just build:

2024-10-22.15-51-43.mp4

@Hoffalypse
Copy link
Contributor Author

OK I may have spoke too soon, I apologize, it was in the merge Queue. Should be GTG now.

Copy link

@mewtwoshaurd mewtwoshaurd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked with new main and seems to work well -- I think I encountered a different UI bug that I'll make a ticket for, but these changes work

@Hoffalypse Hoffalypse merged commit 5639f34 into main Oct 23, 2024
4 checks passed
@Hoffalypse Hoffalypse deleted the removing-primary-view-switch-in-Teleop-Joint-Jog branch October 23, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants