Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean some ARGS in Dockerfile #391

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Clean some ARGS in Dockerfile #391

merged 3 commits into from
Oct 25, 2024

Conversation

chancecardona
Copy link
Contributor

@chancecardona chancecardona commented Oct 22, 2024 •
edited
Loading

This should fix the

=> WARN: InvalidDefaultArgInFrom: Default value for ARG ${MOVEIT_STUDIO_BASE_IMAGE} results in empty or invalid base image

warnings on building this USER WS.

@chancecardona chancecardona self-assigned this Oct 22, 2024
@dsobek
Copy link
Contributor

dsobek commented Oct 22, 2024

LGTM, but this is the first I see this dockerfile. Do you know how this is used?

@chancecardona chancecardona enabled auto-merge (squash) October 25, 2024 23:16
@chancecardona chancecardona merged commit f4be1bf into main Oct 25, 2024
4 checks passed
@chancecardona chancecardona deleted the cleanup-dockerfile-args branch October 25, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsobek dsobek dsobek approved these changes

@dyackzan dyackzan dyackzan approved these changes

Assignees

@chancecardona chancecardona

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chancecardona @dsobek @dyackzan