Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pd): update go version to 1.21 #2350

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

purelind
Copy link
Collaborator

@purelind purelind commented Aug 10, 2023

pd master update go version to 1.21.

Ref tikv/pd#6923

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 10, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Pull Request Review

Summary:
This pull request aims to update the Go version used in the PD Master pipeline from 1.20 to 1.21. The change is implemented by updating the Golang container image used in the pipeline.

Potential problems:

  • There are no potential problems with this change.

Fixing suggestions:

  • None needed.

Overall, this is a simple and straightforward change that updates the Go version used in the pipeline. Therefore, I suggest approving this pull request.

@ti-chi-bot ti-chi-bot bot added the size/XS label Aug 10, 2023
@purelind purelind changed the title feat(pd): master use go1.21 feat(pd): update go version to 1.21 Aug 10, 2023
@purelind
Copy link
Collaborator Author

Ref tikv/pd#6924

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit b08a55a into PingCAP-QE:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant