feature(pingcap/tiflash): intergration support feature branch and ci params in PR title #3042
Conversation
…params in PR title you can append suffix in pr title to set pd and tikv and tidb branch: "| tidb=release-8.2 tikv=feature/xxx pd=master" Fixes #3041 Signed-off-by: wuhuizuo <[email protected]>
Based on the PR title and description, the main change in this pull request is to add support for setting PD, TiKV, and TiDB branches through the PR title. This is achieved by appending a suffix to the PR title, with the desired branch names specified using the format "| tidb=release-8.2 tikv=feature/xxx pd=master". The PR also includes a fix for issue #3041. The diff for the pull request shows that the main changes are in the "pull_integration_test.groovy" file, where the script now computes the branch names from the PR title suffix and passes them as environment variables to the "run.sh" script. One potential problem with this change is that it introduces a new syntax for setting the branches, which may not be immediately obvious to contributors. It's also possible that this syntax could conflict with other tooling that uses "|" as a delimiter. To address these issues, it may be helpful to include some documentation in the PR description or README file explaining how to use this new syntax. It may also be worth considering a more intuitive syntax that is less likely to conflict with other tools. Overall, the changes in this PR seem reasonable and should be helpful for setting up CI/CD pipelines for TiFlash. |
|
testing in: it |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
you can append suffix in pr title to set pd and tikv and tidb branch:
"| tidb=release-8.2 tikv=feature/xxx pd=master"
Fixes #3041
Signed-off-by: wuhuizuo [email protected]