Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pingcap/tidb): intergration support feature branch and ci params in PR title #3045

Conversation

purelind
Copy link
Collaborator

@purelind purelind commented Aug 1, 2024

you can append suffix in pr title to set pd and tikv branch:

"| tikv=feature/xxx pd=master"

default to use master branch bulid binary if not specify in pr title.

Ref #3041

@ti-chi-bot ti-chi-bot bot requested a review from wuhuizuo August 1, 2024 03:16
Copy link

ti-chi-bot bot commented Aug 1, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

The pull request adds support for setting PD and TiKV branches via a suffix in the PR title. The default behavior is to use the master branch if no branch is specified in the PR title. The changes seem reasonable, and there are no apparent problems.

However, it would be helpful to provide more information on how the code has been tested and any potential edge cases that have been considered. Also, it would be good to ensure that the code is backward compatible and doesn't break any existing functionality.

One suggestion for improvement is to add more error handling if the specified branch is not found in the repository. Additionally, adding some documentation on how to use this feature would be helpful for users.

Overall, this pull request seems good. The changes are straightforward, and the code appears to be well-written. So, it can be merged after addressing the above suggestions.

@ti-chi-bot ti-chi-bot bot merged commit 48a4ac8 into PingCAP-QE:main Aug 1, 2024
2 checks passed
Copy link

ti-chi-bot bot commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants