Adjusting date segment

PipedreamHQ · Jun 25, 2024 · 2e5655b · 2e5655b
1 parent 9673236
commit 2e5655b
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 3 deletions.
diff --git a/components/google_ads/actions/create-report/create-report.mjs b/components/google_ads/actions/create-report/create-report.mjs
@@ -95,6 +95,9 @@ export default {
         label: "Segments",
         description: "Select any segments you want to include in your report. See the documentation [here](https://developers.google.com/google-ads/api/fields/v16/segments)",
         options: resource.segments,
+        default: [
+          "date",
+        ],
         optional: true,
         reloadProps: true,
       },
@@ -190,9 +193,9 @@ export default {
       const segments = this.segments?.map((i) => `segments.${i}`) ?? [];
       const metrics = this.metrics?.map((i) => `metrics.${i}`) ?? [];
 
-      if (dateRange && !segments.includes("segments.date")) {
-        segments.push("segments.date");
-      }
+      // if (dateRange && !segments.includes("segments.date")) {
+      //   segments.push("segments.date");
+      // }
 
       const selection = [
         ...fields,

diff --git a/components/google_ads/common/resources/ad.mjs b/components/google_ads/common/resources/ad.mjs
@@ -225,6 +225,7 @@ const segments = [
   "conversion_adjustment",
   "conversion_lag_bucket",
   "conversion_or_adjustment_lag_bucket",
+  "date",
   "device",
   "external_conversion_source",
   "keyword.ad_group_criterion",

diff --git a/components/google_ads/common/resources/adGroup.mjs b/components/google_ads/common/resources/adGroup.mjs
@@ -46,6 +46,7 @@ const segments = [
   "conversion_adjustment",
   "conversion_lag_bucket",
   "conversion_or_adjustment_lag_bucket",
+  "date",
   "device",
   "external_conversion_source",
   "hour",

diff --git a/components/google_ads/common/resources/campaign.mjs b/components/google_ads/common/resources/campaign.mjs
@@ -110,6 +110,7 @@ const segments = [
   "conversion_lag_bucket",
   "conversion_or_adjustment_lag_bucket",
   "conversion_value_rule_primary_dimension",
+  "date",
   "device",
   "external_conversion_source",
   "hour",

diff --git a/components/google_ads/common/resources/customer.mjs b/components/google_ads/common/resources/customer.mjs
@@ -45,6 +45,7 @@ const segments = [
   "conversion_lag_bucket",
   "conversion_or_adjustment_lag_bucket",
   "conversion_value_rule_primary_dimension",
+  "date",
   "device",
   "external_conversion_source",
   "hour",