PR feedback

PipedreamHQ · Sep 8, 2024 · 38be668 · 38be668
1 parent 42c2300
commit 38be668
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/components/puppeteer/actions/common/common.mjs b/components/puppeteer/actions/common/common.mjs
@@ -8,7 +8,7 @@ export default {
     },
   },
   methods: {
-    async run({ $ }) {
+    normalizeUrl() {
       let url = this.url;
       if (!url.startsWith("http")) {
         url = `https://${url}`;

diff --git a/components/puppeteer/actions/get-html/get-html.mjs b/components/puppeteer/actions/get-html/get-html.mjs
@@ -2,6 +2,7 @@ import puppeteer from "../../puppeteer.app.mjs";
 import common from "../common/common.mjs";
 
 export default {
+  ...common,
   key: "puppeteer-get-html",
   name: "Get HTML",
   description:
@@ -13,7 +14,7 @@ export default {
     ...common.props,
   },
   async run({ $ }) {
-    const url = await common.methods.run.call(this, { $ });
+    const url = this.normalizeUrl();
     const browser = await this.puppeteer.launch();
     const page = await browser.newPage();
     await page.goto(url);

diff --git a/components/puppeteer/actions/get-page-title/get-page-title.mjs b/components/puppeteer/actions/get-page-title/get-page-title.mjs
@@ -2,6 +2,7 @@ import puppeteer from "../../puppeteer.app.mjs";
 import common from "../common/common.mjs";
 
 export default {
+  ...common,
   key: "puppeteer-get-page-title",
   name: "Get Page Title",
   description:
@@ -13,7 +14,7 @@ export default {
     ...common.props,
   },
   async run({ $ }) {
-    const url = await common.methods.run.call(this, { $ });
+    const url = this.normalizeUrl();
     const browser = await this.puppeteer.launch();
     const page = await browser.newPage();
     await page.goto(url);

diff --git a/components/puppeteer/actions/get-pdf/get-pdf.mjs b/components/puppeteer/actions/get-pdf/get-pdf.mjs
@@ -4,6 +4,7 @@ import common from "../common/common.mjs";
 import fs from "fs";
 
 export default {
+  ...common,
   key: "puppeteer-get-pdf",
   name: "Get PDF",
   description:
@@ -168,7 +169,7 @@ export default {
       width: this.width,
     };
 
-    const url = await common.methods.run.call(this, { $ });
+    const url = this.normalizeUrl();
     const browser = await this.puppeteer.launch();
     const page = await browser.newPage();
     await page.goto(url);

diff --git a/components/puppeteer/actions/screenshot-page/screenshot-page.mjs b/components/puppeteer/actions/screenshot-page/screenshot-page.mjs
@@ -5,6 +5,7 @@ import fs from "fs";
 import { ConfigurationError } from "@pipedream/platform";
 
 export default {
+  ...common,
   key: "puppeteer-screenshot-page",
   name: "Screenshot a Page",
   description:
@@ -155,7 +156,7 @@ export default {
       type: this.type,
     };
 
-    const url = await common.methods.run.call(this, { $ });
+    const url = this.normalizeUrl();
     const browser = await this.puppeteer.launch();
     const page = await browser.newPage();
     await page.goto(url);