-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Components - clickfunnels #12577
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
WalkthroughThis release introduces multiple new actions and sources for the ClickFunnels integration. Key features include applying or removing tags from contacts, updating or creating contacts based on email, and emitting events for new contact identifications, one-time order payments, and subscription fee payments. Additionally, there's an overhaul of prop definitions and methods for streamlined API interactions. Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Sources - New Contact Identified (Instant) - New One Time Order Paid (Instant) - New Subscription Invoice Paid (Instant) Actions - Apply Tag Contact - Remove Tag Contact - Update Create Contact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 9
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
Files selected for processing (13)
- components/clickfunnels/actions/apply-tag-contact/apply-tag-contact.mjs (1 hunks)
- components/clickfunnels/actions/remove-tag-contact/remove-tag-contact.mjs (1 hunks)
- components/clickfunnels/actions/update-create-contact/update-create-contact.mjs (1 hunks)
- components/clickfunnels/clickfunnels.app.mjs (1 hunks)
- components/clickfunnels/common/utils.mjs (1 hunks)
- components/clickfunnels/package.json (2 hunks)
- components/clickfunnels/sources/common/base.mjs (1 hunks)
- components/clickfunnels/sources/new-contact-identified-instant/new-contact-identified-instant.mjs (1 hunks)
- components/clickfunnels/sources/new-contact-identified-instant/test-event.mjs (1 hunks)
- components/clickfunnels/sources/new-one-time-order-paid-instant/new-one-time-order-paid-instant.mjs (1 hunks)
- components/clickfunnels/sources/new-one-time-order-paid-instant/test-event.mjs (1 hunks)
- components/clickfunnels/sources/new-subscription-invoice-paid-instant/new-subscription-invoice-paid-instant.mjs (1 hunks)
- components/clickfunnels/sources/new-subscription-invoice-paid-instant/test-event.mjs (1 hunks)
Files skipped from review due to trivial changes (3)
- components/clickfunnels/sources/new-contact-identified-instant/test-event.mjs
- components/clickfunnels/sources/new-one-time-order-paid-instant/test-event.mjs
- components/clickfunnels/sources/new-subscription-invoice-paid-instant/test-event.mjs
Additional context used
Biome
components/clickfunnels/common/utils.mjs
[error] 11-11: Avoid the use of spread (
...
) syntax on accumulators. (lint/performance/noAccumulatingSpread)Spread syntax should be avoided on accumulators (like those in
.reduce
) because it causes a time complexity ofO(n^2)
.
Consider methods such as .splice or .push instead.
Additional comments not posted (7)
components/clickfunnels/package.json (2)
3-3
: Version update to 0.1.0The version update from "0.0.1" to "0.1.0" typically indicates significant feature additions or improvements. Ensure that all relevant documentation and user-facing materials reflect this version change.
16-16
: Addition of @pipedream/platform dependencyThe addition of
@pipedream/platform
as a dependency is appropriate given the integration with Pipedream's functionalities. Ensure that this version is compatible with other dependencies and the environment where this package will be deployed.components/clickfunnels/sources/new-one-time-order-paid-instant/new-one-time-order-paid-instant.mjs (1)
4-24
: New Source Module: One-Time Order Paid (Instant)This module is well-structured, extending the common base configurations and methods. The
getEventTypes
andgetSummary
methods are appropriately implemented for the specific event type. Ensure that the sample emit test aligns with the expected data structure of the event.components/clickfunnels/sources/new-subscription-invoice-paid-instant/new-subscription-invoice-paid-instant.mjs (1)
4-24
: New Source Module: Subscription Invoice PaidLike the previous module, this one is well-structured and extends the common base configurations. The specific methods for event types and summaries are correctly implemented for subscription invoice payments. Continue to ensure alignment with the expected data structures and the robustness of the sample emit tests.
components/clickfunnels/sources/new-contact-identified-instant/new-contact-identified-instant.mjs (1)
4-24
: New Source Module: New Contact Identified (Instant)This module extends the common base and is specifically tailored for the event of identifying new or previously anonymous contacts. The methods
getEventTypes
andgetSummary
are well-implemented, providing clear and concise summaries based on the event data. Ensure that the sample emit functionality accurately reflects real-world scenarios.components/clickfunnels/common/utils.mjs (1)
18-41
: Review theparseObject
functionThe
parseObject
function is well-designed to handle different data types and parse JSON strings safely. However, ensure thorough testing, especially with edge cases and malformed JSON strings, to prevent runtime errors.components/clickfunnels/actions/apply-tag-contact/apply-tag-contact.mjs (1)
1-1
: Use relative imports for consistency.Consider using relative imports instead of absolute to ensure the module resolution behaves as expected across different environments.
- import clickfunnels from "../../clickfunnels.app.mjs"; + import clickfunnels from "../clickfunnels.app.mjs";Likely invalid or redundant comment.
components/clickfunnels/actions/remove-tag-contact/remove-tag-contact.mjs
Show resolved
Hide resolved
components/clickfunnels/actions/remove-tag-contact/remove-tag-contact.mjs
Show resolved
Hide resolved
components/clickfunnels/actions/update-create-contact/update-create-contact.mjs
Show resolved
Hide resolved
components/clickfunnels/actions/update-create-contact/update-create-contact.mjs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment. Ready for QA!
...nels/sources/new-subscription-invoice-paid-instant/new-subscription-invoice-paid-instant.mjs
Outdated
Show resolved
Hide resolved
...nels/sources/new-subscription-invoice-paid-instant/new-subscription-invoice-paid-instant.mjs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- components/clickfunnels/sources/new-subscription-invoice-paid-instant/new-subscription-invoice-paid-instant.mjs (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- components/clickfunnels/sources/new-subscription-invoice-paid-instant/new-subscription-invoice-paid-instant.mjs
…instant/new-subscription-invoice-paid-instant.mjs Co-authored-by: michelle0927 <[email protected]>
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- components/clickfunnels/sources/new-subscription-invoice-paid-instant/new-subscription-invoice-paid-instant.mjs (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- components/clickfunnels/sources/new-subscription-invoice-paid-instant/new-subscription-invoice-paid-instant.mjs
Resolves #12570.
Summary by CodeRabbit
New Features
Enhancements
Dependency Updates
@pipedream/platform
version "^3.0.0".