-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Components - faceup #12702
New Components - faceup #12702
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughIn this update, the Changes
Sequence Diagram(s)sequenceDiagram
participant Faceup as Faceup Platform
participant SourceModule as New Source Module
participant HTTP as HTTP Interface
participant Client as Client App
Client->>Faceup: Creates a new resource (comment, message, report)
Faceup->>SourceModule: Sends webhooks for new resource
SourceModule->>SourceModule: run(event) method processes the event
SourceModule->>SourceModule: generateMeta(body) creates metadata
SourceModule->>HTTP: Emits new event with metadata
Note right of SourceModule: Example for 'new-message-instant'
Assessment against linked issues
Possibly related issues
Poem
Tip AI model upgrade
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 9
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- components/faceup/faceup.app.mjs (1 hunks)
- components/faceup/package.json (2 hunks)
- components/faceup/sources/new-internal-comment-instant/new-internal-comment-instant.mjs (1 hunks)
- components/faceup/sources/new-internal-comment-instant/test-event.mjs (1 hunks)
- components/faceup/sources/new-message-instant/new-message-instant.mjs (1 hunks)
- components/faceup/sources/new-message-instant/test-event.mjs (1 hunks)
- components/faceup/sources/new-report-instant/new-report-instant.mjs (1 hunks)
- components/faceup/sources/new-report-instant/test-event.mjs (1 hunks)
Files skipped from review due to trivial changes (5)
- components/faceup/faceup.app.mjs
- components/faceup/package.json
- components/faceup/sources/new-internal-comment-instant/test-event.mjs
- components/faceup/sources/new-message-instant/test-event.mjs
- components/faceup/sources/new-report-instant/test-event.mjs
Additional comments not posted (3)
components/faceup/sources/new-report-instant/new-report-instant.mjs (1)
4-22
: LGTM! Ensure the documentation URL is correct.The component metadata and description are clear and follow best practices. Ensure the documentation URL is correct and accessible.
components/faceup/sources/new-message-instant/new-message-instant.mjs (1)
4-22
: LGTM! Ensure the documentation URL is correct.The component metadata and description are clear and follow best practices. Ensure the documentation URL is correct and accessible.
components/faceup/sources/new-internal-comment-instant/new-internal-comment-instant.mjs (1)
4-22
: LGTM! Ensure the documentation URL is correct.The component metadata and description are clear and follow best practices. Ensure the documentation URL is correct and accessible.
components/faceup/sources/new-internal-comment-instant/new-internal-comment-instant.mjs
Show resolved
Hide resolved
components/faceup/sources/new-internal-comment-instant/new-internal-comment-instant.mjs
Show resolved
Hide resolved
components/faceup/sources/new-internal-comment-instant/new-internal-comment-instant.mjs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @michelle0927, are you sure you commited all files and changes?
@luancazarine Yes. Unfortunately Faceup doesn't have an API Reference, and the only way to create webhooks is within their UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Resolves #12683.
Summary by CodeRabbit
New Features
Version Updates
faceup
component to0.1.0
.Bug Fixes
authKeys
method from thefaceup
component to improve security.Chores
test-event
file to support event emission testing for internal comments, messages, and reports.