[Notion] updated page trigger fix

[andrewjschuang]

When adding a Files & Media property in the database, Notion constantly updates the url and expiry_time values. This causes the trigger to emit multiple events for a page.

According to Notion's documentation: Working with files and media

Each time a database or page is queried, a new public URL is generated for all files hosted by Notion.

This PR makes the trigger ignore changes for url and expiry_time fields for Files & Media properties, but still exports the latest url and expiry_time values whenever there is a change.

Summary by CodeRabbit

• New Features

  • Enhanced handling of page properties in the Notion integration for improved accuracy during updates.
  • Introduced a new method to filter specific fields from file-type properties.

• Version Updates

  • Updated package version for @pipedream/notion from 0.1.22 to 0.1.23.
  • Updated source component version for notion-updated-page from 0.0.17 to 0.0.18.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	⬜️ Ignored (Inspect)	Visit Preview		Sep 26, 2024 8:41pm
pipedream-docs	⬜️ Ignored (Inspect)			Sep 26, 2024 8:41pm
pipedream-docs-redirect-do-not-edit	⬜️ Ignored (Inspect)			Sep 26, 2024 8:41pm

[coderabbitai]

Walkthrough

This pull request includes updates to the @pipedream/notion package, specifically changing the version number in the package.json file from 0.1.22 to 0.1.23. Additionally, the notion-updated-page source component has been updated, with its version incremented from 0.0.17 to 0.0.18. The changes enhance the handling of page properties by introducing new methods for filtering specific fields from file-type properties during updates.

Changes

File	Change Summary
components/notion/package.json	Version updated from 0.1.22 to 0.1.23.
components/notion/sources/updated-page/...	Version updated from 0.0.17 to 0.0.18; modified core logic to improve property handling with new methods calculateHash and maybeRemoveFileSubItems.

Possibly related PRs

• Notion - updated page trigger fix #13972: This PR updates the version number of the @pipedream/notion package in package.json, similar to the main PR.
• Notion - updated-page source improvements #14045: This PR updates the version number of the @pipedream/notion package in package.json and modifies the notion-updated-page source, relevant to the changes made in the main PR.

Suggested reviewers

• jcortes
• luancazarine

Poem

🐇 In the garden of code, we hop with delight,
Versions updated, everything feels right.
Properties filtered, clarity shines through,
With every small change, our features renew.
So here's to the updates, both big and small,
A leap for the Notion, let's celebrate all! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between fab4297 and 3473e23.

📒 Files selected for processing (2)

• components/notion/package.json (1 hunks)
• components/notion/sources/updated-page/updated-page.mjs (4 hunks)

✅ Files skipped from review due to trivial changes (1)

• components/notion/package.json

🧰 Additional context used

🪛 Biome

components/notion/sources/updated-page/updated-page.mjs

[error] 91-91: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

🔇 Additional comments (1)

components/notion/sources/updated-page/updated-page.mjs (1)

85-95: Use of delete operator is appropriate in this context

While static analysis warns about the performance impact of using the delete operator, deleting file.file is necessary here to remove the property entirely before serialization and hashing. Assigning undefined would leave the property in the object, which could lead to incorrect hash computations. The performance impact is negligible in this context.

🧰 Tools

🪛 Biome

[error] 91-91: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

[andrewjschuang]

Related to #13773