Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Components] Translate.com #8187 #8258

Merged
merged 6 commits into from
Oct 1, 2023
Merged

[Components] Translate.com #8187 #8258

merged 6 commits into from
Oct 1, 2023

Conversation

lcaresia
Copy link
Collaborator

@lcaresia lcaresia commented Sep 27, 2023 •
edited by ghost
Loading

WHAT

🤖 Generated by Copilot at 63f0a35

This pull request adds a new action component to the translate_com app that lets users translate text using the translate.com API. It also updates the app file, the package.json file, and the pnpm-lock.yaml file to support the new component. It deletes some unused files from the translate_com app folder.

🤖 Generated by Copilot at 63f0a35

translate_com app
adds machine translation
a new action component

WHY

HOW

🤖 Generated by Copilot at 63f0a35

  • Add a new action component to translate text using the translate_com API (link)
  • Update the package.json file to increment the version and change the main field (link)
  • Add the app file that defines the common methods and prop definitions for the translate_com components (link)
  • Delete the unused files .gitignore and app/translate_com.app.ts (link, link)
  • Add a dependency entry for the modeck component to the pnpm-lock.yaml file (link)

@lcaresia lcaresia added the action New Action Request label Sep 27, 2023
@lcaresia lcaresia self-assigned this Sep 27, 2023
@vercel
Copy link

vercel bot commented Sep 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pipedream-docs 🛑 Canceled (Inspect) Sep 27, 2023 2:42pm
pipedream-docs-redirect-do-not-edit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 2:42pm

@lcaresia lcaresia linked an issue Sep 27, 2023 that may be closed by this pull request
[Components] Translate.com #8187
Closed
jcortes
jcortes reviewed Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@jcortes jcortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lcaresia just have to fix a minor typos there. Other than that LGTM! Ready for QA!

components/translate_com/translate_com.app.mjs Outdated Show resolved Hide resolved
components/translate_com/translate_com.app.mjs Outdated Show resolved Hide resolved
components/translate_com/actions/translate-text/translate-text.mjs Outdated Show resolved Hide resolved
@lcaresia
Copy link
Collaborator Author

/approve

jcortes
jcortes approved these changes Sep 30, 2023
View reviewed changes
Copy link
Collaborator

@jcortes jcortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@lcaresia lcaresia merged commit f9943be into master Oct 1, 2023
10 checks passed
@lcaresia lcaresia deleted the translate-8187 branch October 1, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcortes jcortes jcortes approved these changes

Assignees

@lcaresia lcaresia

Labels
action New Action Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Components] Translate.com
2 participants
@lcaresia @jcortes