I changed the included color functions to consts and added a "TRANSPARENT" color #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd updated the examples to work with the changes
| use conrod::{Button, Colorable, Labelable, Positionable, Sizeable, Tabs, Text, WidgetMatrix}; | ||
|
|
||
| // Construct our main `Canvas` tree. | ||
| Canvas::new().flow_down(&[ | ||
| (HEADER, Canvas::new().color(blue()).pad_bottom(20.0)), | ||
| (HEADER, Canvas::new().color(::conrod::color::BLUE).pad_bottom(20.0)), |
There was a problem hiding this comment.
If possible, could you import the color module and instantiate these colors like color::BLUE instead of ::conrod::color::BLUE?
|
Nice one, thanks a lot for this, really appreciate it! If you could make the change I suggested in the other comment, I'll merge this 😸 |
…onrod::color::BLUE for example
|
I made that change! Feel free to merge if you see fit. Else, tell me what to change! 😃 |
|
LGTM! 👍 Travis is failing due to a regression in the latest nightly, but it's building fine on stable so will merge :) I'll increment the version and publish this to crates.io a little later on. |
mitchmindtree
added a commit
that referenced
this pull request
Dec 23, 2015
I changed the included color functions to consts and added a "TRANSPARENT" color
|
These breaking changes have been published to crates.io under version 0.29.0, along with the breaking changes in #662. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also updated the examples to work with the new changes made.
I made these changes in accordance with issue #638. Everything is working properly.