Fix UnrepresentableType error message #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of the `unrepresentable` macro attempts to pass `$type` as the message for the `UnrepresentableType` error. However, macro parameters are not expanded inside strings, so the error message would appear as "$type" instead of "u8" or "u16." The bug was fixed using the `stringify` macro. bla
|
Ah, good catch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the
unrepresentablemacro attempts to pass$typeas the message for the
UnrepresentableTypeerror. However, macro parametersare not expanded inside string literals, so the error message appeared as "$type" instead
of "u8" or "u16." The bug was fixed using the
stringifymacro.