Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gfx_device_gl dependency #263

Closed
smolck opened this issue Sep 1, 2019 · 4 comments · Fixed by #265
Closed

Update gfx_device_gl dependency #263

smolck opened this issue Sep 1, 2019 · 4 comments · Fixed by #265

Comments

@smolck
Copy link

smolck commented Sep 1, 2019

Hello! After trying to run the example given here on the main Piston repo using piston_window version 0.103.0 (I believe the same happens on v0.98.0, but would need to verify), I got two errors when compiling gfx_device_gl (on latest nightly) that looked a bit like this:

failed to resolve: could not find `format args` in `core`

Upon further investigation, it appears to be a bug in gfx_device_gl version 0.16.1 (and apparently older versions since AFAIK piston_window version 0.103.0 uses gfx_device_gl version 0.15.0, right?). The issue on gfx_device_gl is here:
gfx-rs/gfx#2964

The bug is fixed in gfx_device_gl version 0.16.2. Would it be feasible to upgrade piston_window's dependency on gfx_device_gl to version 0.16.2 to fix this? If not, is there another way to fix this?

Thanks!

@bvssvni
Copy link
Member

bvssvni commented Sep 3, 2019

This is done automatically by cargo update.

@smolck
Copy link
Author

smolck commented Sep 4, 2019

I’m speaking of the dependency here in Cargo.toml. cargo update doesn’t change the Cargo.toml file (at least for me). Should it?

@AgustinCB
Copy link

I have the same problem. Is this going to be updated?

@bvssvni
Copy link
Member

bvssvni commented Sep 13, 2019

Todo:

  • Update "piston-gfx_texture"
  • Update "piston2d-gfx_graphics"
  • Update "piston_window"

bvssvni added a commit to bvssvni/piston_window that referenced this issue Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants