Make keepalive variable local #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should prevent the race conditions when destroying and initializing multiple threadpools at the same time
|
I'm fully agree with this proposal. |
ashtul
approved these changes
Mar 20, 2022
Pithikos
reviewed
Dec 18, 2023
| @@ -53,11 +53,8 @@ | |||
| #define STRINGIFY(x) #x | |||
| #define TOSTRING(x) STRINGIFY(x) | |||
|
|
|||
| static volatile int threads_keepalive; | |||
| static volatile int threads_on_hold; | |||
There was a problem hiding this comment.
I think that if we are to fix this, we should also consider an approach for threads_on_hold
Also some test coverage would be nice demonstrating the original issue and to avoid regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent the race conditions when destroying and initializing multiple threadpools at the same time
Also see #88