Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PointInstancer has to support full precision orientation. #2529

Closed
YKZDY opened this issue Jul 10, 2023 · 6 comments
Closed

PointInstancer has to support full precision orientation. #2529

YKZDY opened this issue Jul 10, 2023 · 6 comments

Comments

@YKZDY
Copy link

YKZDY commented Jul 10, 2023

Reference

https://groups.google.com/g/usd-interest/c/ID-9MQKktWc

Description of Issue

As discussed with Spiff in the attached thread, the half-precision orientation is not accurate enough to layout assets in a big world, like every window, door, and brick in the modern city, especially when they have a 90/180/270 rotation.

Spiff was purposed to have an updated schema that supports "orientationsf" as an optional attribute. I believe it will relieve the inaccuracy, and even maybe having an optional "orientationsd" as well sounds like a good idea to me :)

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-8486

pixar-oss added a commit that referenced this issue Feb 5, 2024
See #2529

(Internal change: 2313218)
@asluk
Copy link
Collaborator

asluk commented Feb 27, 2024

The original thread in https://groups.google.com/g/usd-interest/c/ID-9MQKktWc mentioned versioning the PointInstancer schema for this; is that still worth doing? 🙏🏼

@YKZDY
Copy link
Author

YKZDY commented Feb 27, 2024

Hey Aaron, nice to meet you here.
As far as our practice, it really depends on the way you are using PointInstancer. It would be fine if you are scattering trees, sand, or rocks, but you will find the artifacts if you are trying to assemble a building from bricks far from the origin.

By the way, the Large World Coordinates feature of UE5 makes this a priority for us.

@asluk
Copy link
Collaborator

asluk commented Feb 27, 2024

Hi @YKZDY , yes I meant that is it worth using schema versioning, e.g., PointInstancer_01, to make it clear that point instancer content that has the new orientationsf attribute are not honored in older releases of OpenUSD < v24.03 .

@spiffmon
Copy link
Member

We discussed it internally, @asluk , and according to the guidelines laid out in the proposal, it did not warrant a version bump and the larger code changes that would have required. Maybe we use this as a test-case for those guidelines, along with the recent changes to DomeLight that did warrant a version bump?

@asluk
Copy link
Collaborator

asluk commented Feb 29, 2024

sounds fair; thanks @spiffmon

pixar-oss added a commit that referenced this issue Mar 1, 2024
…s in

hdSt/instancer.cpp. Expect newer types to be added/updated and older types to be
removed.

Fixes #2529

(Internal change: 2316320)
pixar-oss added a commit that referenced this issue Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants