Added support for python 3.8 on windows by explicitely loading dlls #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: CI failing on mac during PySide2 installation: |
meshula
reviewed
Dec 22, 2020
|
Filed as internal issue #USD-6530 |
|
Hi @rdeioris, thanks for this PR! We think there are some issues with this approach though. In particular, this change permanently modifies Python's DLL search path once any USD module is imported. Also, I think this change works well for USD builds done via build_usd.py since USD and all of its dependencies are in a well-known location, but may not work for "manual" builds of USD where the dependencies may live in other locations. We're actually in progress right now on this issue and hope to have something shortly. So I'm going to close this PR out, but thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone, this patch adds support for python >= 3.8 on windows systems.
The fix works by explicitly adding the dll paths at runtime (by importing an ad-hoc module in the pxr/init.py module)
It should fix #1404