Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Storm code generation from USD PreviewSurface for GLSL bindings to primvars #1863

Merged

Conversation

marktucker
Copy link
Contributor

Description of Change(s)

Fix code generation for GLSL bindings to primvars. This type of binding was missing the definition of HdGetScalar_name to call HdGet_name.

I'm fairly out of my depth with this change, so I'm not sure if this is the right approach. But in the specific case of opacity reported in issue #1862, this change fixes the code generation and the material works as expected.

Fixes Issue(s)

was missing the definition of HdGetScalar_name to call HdGet_name.
@jilliene
Copy link

Filed as internal issue #USD-7375

@davidgyu
Copy link
Member

Thanks, Mark! This fix looks good to me, and thank you for the test case in #1862 We'll make sure to add a case for this to our test suite and get the fix merged.

@pixar-oss pixar-oss merged commit 25e029e into PixarAnimationStudios:dev Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants