Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two small improvements to the OBJ plugin #2092

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

nicolaspopravka
Copy link
Contributor

@nicolaspopravka nicolaspopravka commented Nov 15, 2022

Description of Change(s)

The proposed changes slightly improve the example plugin to convert between the OBJ file format and USD, and hopefully make it even more useful ;-)

Fixes Issue(s)

  • OBJ files with no g statements, or a g statement not followed by a group name, could not be referenced in. With this change, one is now able to do so, like this:
def Mesh "default" (
    prepend references = @mesh.obj@</default>
 )
 {
 }
  • OBJ files with vt statements could not be rendered with textures when referenced in. This is fixed.
  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@sunyab
Copy link
Contributor

sunyab commented Nov 19, 2022

Filed as internal issue #USD-7777

@nicolaspopravka
Copy link
Contributor Author

@sunyab I see you've filed this PR as an internal issue. What is generally to be expected from this ? Thanks.

@sunyab
Copy link
Contributor

sunyab commented Jan 3, 2023

Hi @nicolaspopravka, the internal issue number is just for bug tracking purposes on our side and indicates that we've queued this PR for triage and prioritization.

@pixar-oss pixar-oss merged commit 2331d5c into PixarAnimationStudios:dev Nov 1, 2023
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants