Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost::iterator_adaptor with explicitly specified iterator definition for UsdPrim{Sibling,Subtree}Iterator #2234

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Feb 1, 2023

Description of Change(s)

  • Introduces an _UnderlyingIterator type alias for const Usd_PrimData* in UsdPrimSiblingIterator
  • Introduces an _UnderlyingIterator type alias for const UsdPrimDataConstPtr in UsdPrimSubtreeIterator
  • Introduces _PtrProxy private classes to be used as the pointer type for UsdPrimSiblingIterator and UsdPrimSubtreeIterator. This special proxy is required because their reference type aliases are not true reference types and it's not safe to take the address of a temporary.
  • Explicitly implements the increment, dereference, equality and arrow operators for UsdPrimSiblingIterator and UsdPrimSubtreeIterator
  • Fix doxygen string for pre/post increment operators

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-7962

@nvmkuruc nvmkuruc force-pushed the usdprimadaptor branch 4 times, most recently from 6f2872d to bab93a8 Compare February 20, 2023 00:45
…definition for `UsdPrim{Sibling,Subtree}Iterator`
@pixar-oss pixar-oss merged commit 2831860 into PixarAnimationStudios:dev Jul 27, 2023
2 of 20 checks passed
@nvmkuruc nvmkuruc deleted the usdprimadaptor branch December 29, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants