Add support for long Windows paths #2239
Conversation
mistafunk
force-pushed
the
windows-long-paths-support
branch
2 times, most recently
from
b457c34
to
3bee74b
Compare
|
Looking into the compile issues... |
mistafunk
force-pushed
the
windows-long-paths-support
branch
from
3bee74b
to
23d9990
Compare
|
Looks promising! Out of curiosity, I noticed you removed the Debug target, which I assume is a temporary development detail. Is there some aspect of Debug that was getting in the way, or is it just a patch to streamline a workflow you have? |
|
Filed as internal issue #USD-7967 |
mistafunk
force-pushed
the
windows-long-paths-support
branch
from
23d9990
to
561f068
Compare
Thanks. I saw CMake install errors regarding Anyways, I'm working on another PR iteration and will trigger a review request once I'm ready. |
mistafunk
force-pushed
the
windows-long-paths-support
branch
from
561f068
to
674c7d6
Compare
|
Re: testArchStackTrace.pdb, see #2179 |
mistafunk
force-pushed
the
windows-long-paths-support
branch
from
674c7d6
to
c6c819a
Compare
|
@meshula I've rebased the PR to latest dev and expanded the test coverage a bit. Please note, I've yet to backport these changes to our product and test them there. But I consider the changes done. |
|
Before merging, the (Stumbled over this while adding long path support to another library.) |
|
Hey guys, just checking on the status of this as it appears the discussion has been inactive for a while. Besides the review is there anything else that's preventing this from moving forwards? We are experiencing this issue at the moment and considering our options :) |
|
Hi, the ball is with Pixar :-) I'm happy to receive feedback and work some more on this... |
|
@mistafunk , it's taken awhile, but this has, coincidentally, recently finally risen to near top of queue, and we'll be having a look shortly. Can't promise it will make it in to 24.08, but soon. |
pxr/base/arch/fileSystem.cpp
Outdated
| @@ -648,21 +762,27 @@ MakeUnique( | |||
|
|
|||
| #endif | |||
|
|
|||
| namespace { | |||
|
|
|||
| const std::string TMPDIR_FMT = std::string("%s") + ARCH_PATH_SEP + "%s.XXXXXX"; | |||
There was a problem hiding this comment.
Can this just be a literal? "%s" ARCH_PATH_SEP "%s.XXXXXX" ?
There was a problem hiding this comment.
good catch, will turn this into a constexpr const char*
|
/AzurePipelines run |
|
Pull request contains merge conflicts. |
mistafunk
force-pushed
the
windows-long-paths-support
branch
from
c6c819a
to
5e7979e
Compare
|
/AzurePipelines run |
|
Commenter does not have sufficient privileges for PR 2239 in repo PixarAnimationStudios/OpenUSD |
mistafunk
force-pushed
the
windows-long-paths-support
branch
from
5e7979e
to
3f21468
Compare
…ong path handling
mistafunk
force-pushed
the
windows-long-paths-support
branch
from
3f21468
to
878fe1e
Compare
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Oops, let me take care of the compile issues on Linux/macOS... |
mistafunk
force-pushed
the
windows-long-paths-support
branch
from
878fe1e
to
dfe27db
Compare
|
Force pushed the last two commits and fixed Linux build by adding a missing |
Description of Change(s)
Prefix all file system paths longer than 248 characters with "\\?\" before passing into Win32 File I/O API functions.
Fixes Issue(s)
Avoids errors when reading/writing USD files on long Windows paths.
Notes
The CLA is pending on my side.This PR is not complete yet (Arch and Tf test coverage). I submit it early to get some basic feedback.This PR contains temporary/helper commits not intended for merge.