Replace boost hash usage with TfHash in pxr/base/gf #2289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This is a reconstruction #2175 which didn't get successfully merged.
Requires: #2173
To remove the dependency of pxr/base/gf on boost's hashing functions
Gf.Rotation
,Gf.Quaternion
,Gf.Interval
)__hash__
operator overloads are added when missing to support test coverage (Gf.BBox3d
,Gf.Frustum
,Gf.Quat{f,h,d}
,Gf.Rect2i
,Gf.Rotation
)__hash__
test coverage added totestGfRotation
,testGfVec
,testGfRect2i
,testGfRange
,testGfQuarternion
,testGfMatrix
,testGfInterval
,testGfFrustum
,testGfDualQuaternion
,testGfBBox3d
, andtestGfFrustum
.boost::hash_combine
withTfHash::Combine
inhash_value
implementations. Preservinghash_value
allowsboost::hash
to still work with these types without the explicit dependency.TfHash
will use thesehash_value
implementations when noTfHashAppend
overload has been provided.Fixes Issue(s)
-#2172 (more PRs forthcoming)