Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace boost::iterator_facade with explicit iterator for TfDenseHashMap #2308

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Replace boost::iterator_facade with explicit iterator for TfDenseHashMap #2308

merged 1 commit into from
Jul 27, 2023

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Feb 22, 2023 •
edited
Loading

Description of Change(s)

  • Remove spurious include of boost/iterator/iterator_facade.hpp in pxr/base/tf/denseHashSet.h
  • Explicitly implement _IteratorBase for TfDenseHashMap
  • Make empty _IteratorBase constructor default instead of empty

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-8049

@pixar-oss pixar-oss merged commit 6924023 into PixarAnimationStudios:dev Jul 27, 2023
@nvmkuruc nvmkuruc deleted the tfdenseiteratorfacade branch December 29, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvmkuruc @tallytalwar @pixar-oss