APPLE: Disable presentation in UsdAppUtilsFrameRecorder #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-8254 |
creijon
force-pushed
the
jon/dev/no_presentation_in_framerecorder
branch
4 times, most recently
from
d28dfe6
to
f0e0d9a
Compare
creijon
force-pushed
the
jon/dev/no_presentation_in_framerecorder
branch
from
f0e0d9a
to
46c7988
Compare
creijon
force-pushed
the
jon/dev/no_presentation_in_framerecorder
branch
2 times, most recently
from
fffc809
to
96723d7
Compare
creijon
force-pushed
the
jon/dev/no_presentation_in_framerecorder
branch
from
96723d7
to
914e367
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
The
UsdImagingGLEngineinUsdAppUtilsFrameRecorderhasHdxPresentTaskpresentation enabled by default. When this is used in Metal this means that the openGL context is still required. Since the frame recorder doesn't present to the viewport we should disable this.Addendum: the presentation flag is also reset to enabled if the renderer plugin is changed after the frame recorder is created, so it is now set to disabled then too.
Fixes Issue(s)