Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow instancing of bounding boxes drawn on prims with unloaded payloads #2408

Conversation

marktucker
Copy link
Contributor

Allow instancing of bounding boxes drawn on prims with unloaded payloads.

Description of Change(s)

Reordered code in UsdImagingDelegate::_AdapterLookup to check for IsInstanceable before checking for IsLoaded. This allows the instancer adapter to instance the bounding box rprims created for instanceable prims with unloaded payloads. Previously even with the instanceable flag set, every unloaded payload prim would create a separate rprim for its bounding box.

This change also required changing the draw mode adapter because that code was explicitly compensating for the fact that unloaded payload prims were not being instanced properly.

  • [ X ] I have verified that all unit tests pass with the proposed changes
  • [ X ] I have submitted a signed Contributor License Agreement

@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-8273

@pixar-oss pixar-oss merged commit 1a9f97f into PixarAnimationStudios:dev Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants