[usdAbc] Reenable USD_ABC_READ_ARCHIVE_USE_MMAP #2439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The USD_ABC_READ_ARCHIVE_USE_MMAP TfGetEnvSetting was defined but had no effect when set. Originally intended to allow for the user to choose between pread and mmap, the functionality was lost in commit 5a795b2. We restore that functionality and change USD_ABC_READ_ARCHIVE_USE_MMAP's default from 'false' to 'true' to match the current behavior of Alembic 1.7.9+ and the usdAbc plugin.
|
Filed as internal issue #USD-8353 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change a user may set USD_ABC_READ_ARCHIVE_USE_MMAP=0 to disable memory map read support.
Description of Change(s)
The USD_ABC_READ_ARCHIVE_USE_MMAP TfGetEnvSetting was defined but had no effect when set. Originally intended to allow for the user to choose between pread and mmap, the functionality was lost in commit 5a795b2.
We restore that functionality and change USD_ABC_READ_ARCHIVE_USE_MMAP's default from 'false' to 'true' to match the current behavior of Alembic 1.7.9+ and the usdAbc plugin.
Fixes Issue(s)