Replace deprecated QFontMetrics.width with horizontalAdvance #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le since Qt 5.11)
|
Filed as internal issue #USD-8628 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
usdview was using a deprecated
widthmethod onQFontMetricsthat was finally dropped in Qt6.This PR (thanks to John Hood for the fix) replaces it with
horizontalAdvanceThis method has been available since Qt 5.11 and is the recommended replacement per https://doc.qt.io/qt-5/qfontmetrics-obsolete.html#width
Since this encompasses every version of the VFX Platform setup, I haven't tried to maintain compatibility behind 5.11
Fixes Issue(s)